validation: make CScriptCheck and prevector swap members noexcept #25017

1. 
   jonatack commented at 5:33 pm on April 28, 2022: member

   along with those seen elsewhere in the codebase (prevector and checkqueue units/fuzz/bench).

   A swap must not fail; when a class has a swap member function, it should be declared noexcept. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c84-a-swap-function-must-not-fail

2. jonatack force-pushed on Apr 28, 2022
3. DrahtBot added the label Validation on Apr 28, 2022
4. 
   laanwj commented at 5:43 pm on April 28, 2022: member

   Concept ACK. Do we have any other swap member functions?
5. jonatack renamed this:
   validation: make the CScriptCheck::swap() member function `noexcept`
   validation: make CScriptCheck and prevector swap members noexcept
   on Apr 28, 2022
6. validation: make CScriptCheck and prevector swap member functions noexcept

   Reason:
   A swap must not fail; when a class has a swap member function, it should be declared noexcept.
   https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c84-a-swap-function-must-not-fail

   abc1ee5090
7. vincenzopalazzo approved
8. 
   vincenzopalazzo commented at 6:31 pm on April 28, 2022: none

   ACK https://github.com/bitcoin/bitcoin/pull/25017/commits/01e223ff9d9c3851395ed6e883fca509f2f0f4a4
9. test, bench: make prevector and checkqueue swap member functions noexcept

   Reason:
   A swap must not fail; when a class has a swap member function, it should be declared noexcept.
   https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c84-a-swap-function-must-not-fail

   e5485e8e4b
10. jonatack force-pushed on Apr 28, 2022
11. 
    jonatack commented at 6:35 pm on April 28, 2022: member

    Concept ACK. Do we have any other swap member functions?

    Added the remaining ones found with git grep "void swap" and looking through git grep -C3 "std::swap" … critical code in one commit, and test/bench in a second one.

12. 
    pk-b2 commented at 5:51 am on May 2, 2022: none

    ACK https://github.com/bitcoin/bitcoin/pull/25017/commits/e5485e8e4be7f2ee0671f58c3dcce35c68ba0ee0
13. w0xlt approved
14. 
    w0xlt commented at 11:37 am on May 2, 2022: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/25017/commits/e5485e8e4be7f2ee0671f58c3dcce35c68ba0ee0

    These changes make the code conform to the C.85: Make swap noexcept directive.

15. MarcoFalke merged this on May 2, 2022
16. MarcoFalke closed this on May 2, 2022

    ---

17. jonatack deleted the branch on May 2, 2022
18. sidhujag referenced this in commit 503476c73a on May 2, 2022
19. Fabcien referenced this in commit dfa3cc728d on Feb 28, 2023
20. DrahtBot locked this on May 2, 2023

Contributors
jonatack laanwj vincenzopalazzo pk-b2 w0xlt

Labels
Validation