@jonasschnelli Can you verify if this is needed, at least it seems to be missing as we have THIS in the current code: https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoingui.cpp#L317
Bitcoin-Qt: add missing setIcon() for MacDoc when on Mac #2502
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:mac_fix changing 1 files +1 −0-
Diapolo commented at 1:59 PM on April 10, 2013: none
-
Bitcoin-Qt: add missing setIcon() for MacDoc when on Mac 415cf5d6cc
-
jonasschnelli commented at 2:08 PM on April 10, 2013: contributor
In my eye and also after tests there is no need for that. It was somehow a hack which had set a empty dock menu. I'll also wrote a info to the dev who did code this why he did that (for 2 days)... no response yet.
-
jonasschnelli commented at 2:09 PM on April 10, 2013: contributor
or... is there a chance that the client switches during the runtime from testnet to prod-net?
-
sipa commented at 2:10 PM on April 10, 2013: member
@jonasschnelli No, that's not possible.
-
jonasschnelli commented at 2:13 PM on April 10, 2013: contributor
then i don't see a need for that line.
-
Diapolo commented at 2:23 PM on April 10, 2013: none
But is the icon set as default anywhere then or can we remove the one for testnet?
-
jonasschnelli commented at 2:28 PM on April 10, 2013: contributor
the "normal" icon is set by the application bundle. But when the user start the app with -testnet, the icon will then be changed by QT (mac bridge code) in runtime. So the "testnet line" we need. But we once need it at another point in code (but this will be a new pull request once).
-
Diapolo commented at 2:39 PM on April 10, 2013: none
Okay, closing this then :).
- Diapolo closed this on Apr 10, 2013
- DrahtBot locked this on Sep 8, 2021
Contributors