rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height #25026

pull aureleoules wants to merge 1 commits into bitcoin:master from aureleoules:2022-04-pruneblockchain-fetch-old-blocks changing 3 files +48 −5
  1. aureleoules commented at 10:11 AM on April 29, 2022: member

    Implements #24286.

    This change allows pruned nodes to fetch older blocks from peers when pruning with a height that is lower than the current pruned height. This makes use of #20295. The peer used to fetch blocks is by default the peerid 0. I have added a functional test.

  2. DrahtBot added the label RPC/REST/ZMQ on Apr 29, 2022
  3. DrahtBot added the label Needs rebase on Apr 29, 2022
  4. aureleoules marked this as a draft on Apr 29, 2022
  5. aureleoules force-pushed on Apr 29, 2022
  6. DrahtBot removed the label Needs rebase on Apr 29, 2022
  7. aureleoules force-pushed on Apr 29, 2022
  8. aureleoules marked this as ready for review on Apr 29, 2022
  9. DrahtBot commented at 6:07 AM on May 2, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19792 (rpc: Add dumpcoinstats by fjahr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. luke-jr commented at 10:13 PM on May 7, 2022: member

    Concept and Approach NACK. Feels too much like a hack to do it this way IMO. At the very least, I think it should require an explicit opt-in to the new behaviour, but I'm not sure there's a good use case either. It would make more sense to fetch old blocks as needed (eg, transparently in getblock)

  11. rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height c00d8c3f5b
  12. aureleoules force-pushed on May 14, 2022
  13. aureleoules closed this on May 14, 2022

  14. aureleoules deleted the branch on Aug 25, 2022
  15. bitcoin locked this on Aug 25, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me