add explicit condition fo master fingerprint to be lowercase hex #25033

pull scgbckbone wants to merge 1 commits into bitcoin:master from scgbckbone:explicit_master_fp_str_encoding_in_docs changing 1 files +1 −1
  1. scgbckbone commented at 3:39 PM on April 29, 2022: none

    Without this or this PRs going inside, core should explicitly state which hex representation of master fingerprint should external signer use (lower/upper).

    If one of those make it in - MUST should be changed to SHOULD

  2. add explicit condition fo master fingerprint to be lowercase hex 7d9b3529fa
  3. DrahtBot added the label Docs on Apr 29, 2022
  4. fanquake requested review from Sjors on May 6, 2022
  5. fanquake requested review from achow101 on May 6, 2022
  6. luke-jr commented at 1:21 AM on May 8, 2022: member

    NACK, #25019 is the right approach. Comparing hex strings is silly.

  7. Sjors commented at 4:05 PM on May 10, 2022: member

    I'm fairly confident #25019 will make it, so you can close this.

  8. MarcoFalke commented at 4:08 PM on May 10, 2022: member

    Closing for now. Let us know if this should be reopened.

  9. MarcoFalke closed this on May 10, 2022

  10. DrahtBot locked this on May 10, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me