Reject invalid rpcauth formats #25043

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-rpcauth-invalid-format-🍰 changing 2 files +10 −8

MarcoFalke commented at 10:58 AM on April 30, 2022: member

This was added in commit 438ee59839ad49bf629452279478462c987b7137, but I couldn't determine if it was intentional.

One reason to accept foo:bar:baz over foo:bar$baz is that $ may be eaten by the shell. Though, I don't think many users pass rpcauth via the shell. Also it should be easy to avoid by passing '-rpcauth=foo:bar$baz' or "-rpcauth=foo:bar\$baz".

Can be tested with the added test.
Reject invalid rpcauth formats fa12706fc6
MarcoFalke added the label RPC/REST/ZMQ on Apr 30, 2022
pk-b2 commented at 4:08 AM on May 1, 2022: none

ACK fa12706fc6dbaf82eca37f30afa07c37fcd44932

Tested various patterns manually. Behaves now as expected with the patch.
MarcoFalke deleted a comment on May 1, 2022
fanquake merged this on May 1, 2022
fanquake closed this on May 1, 2022
MarcoFalke deleted the branch on May 2, 2022
sidhujag referenced this in commit 759e3fe34d on May 2, 2022
DrahtBot locked this on May 2, 2023

Contributors

Labels