This PR adds test coverage for invalid requests (Invalid hash and Unknown filtertype) for /blockfilterheaders in REST functional test.
test: add coverage for invalid requests for `blockfilterheaders` (REST) #25045
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-04-invalid-blockfilterheaders changing 1 files +7 −1-
brunoerg commented at 9:17 PM on April 30, 2022: member
- brunoerg renamed this:
test: add coverage for invalid requests for `blockfilterheaders`
test: add coverage for invalid requests for `blockfilterheaders` (REST)
on Apr 30, 2022 - fanquake added the label Tests on Apr 30, 2022
-
jacobpfickes commented at 3:16 AM on May 2, 2022: contributor
ACK f11b8216fe6ec79b23c603ac185095222d0e9ff5
Pulled and verified additions. Great work
-
jonatack commented at 2:50 PM on May 3, 2022: member
Light ACK f11b8216fe6ec79b23c603ac185095222d0e9ff5, this builds on and is similar to predecessor commit bd52684508c
Should the logging be updated? e.g.
--- a/test/functional/interface_rest.py +++ b/test/functional/interface_rest.py @@ -219,7 +219,7 @@ class RESTTest (BitcoinTestFramework): self.generate(self.nodes[0], 1) # generate block to not affect upcoming tests - self.log.info("Test the /block, /blockhashbyheight and /headers URIs") + self.log.info("Test the /block, /blockhashbyheight, /headers, and /blockfilterheaders URIs") bb_hash = self.nodes[0].getbestblockhash() -
-
test: add coverage for invalid requests for `blockfilterheaders` d1bfe5ebdb
- brunoerg force-pushed on May 3, 2022
-
jonatack commented at 6:43 PM on May 3, 2022: member
ACK d1bfe5ebdb3d40dd45f97c751c49ebe2c549c1bc
- vincenzopalazzo approved
-
vincenzopalazzo commented at 8:31 PM on May 3, 2022: none
- MarcoFalke merged this on May 4, 2022
- MarcoFalke closed this on May 4, 2022
-
w0xlt commented at 8:33 AM on May 4, 2022: contributor
- sidhujag referenced this in commit 8b5c47fda1 on May 4, 2022
- DrahtBot locked this on May 4, 2023
Contributors
Labels