rpc: Move output script RPCs to separate file, rename misc.cpp #25058

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2205-rpc-out-script-📂 changing 4 files +329 −290

MarcoFalke commented at 7:06 AM on May 3, 2022: member

RPCs handling output scripts (addresses, scriptPubKeys, and output script descriptors) should not be placed in a file called misc.cpp, so move them out, then rename misc.cpp.

rpc: Move output script RPCs to separate file

Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

fa87eb8ce1

scripted-diff: Rename rpc/misc.cpp to rpc/node.cpp

-BEGIN VERIFY SCRIPT-
 git mv src/rpc/misc.cpp src/rpc/node.cpp
 sed -i 's@rpc/misc.cpp@rpc/node.cpp@g' $(git grep -l misc.cpp)
 sed -i 's,RegisterMiscRPCCommands,RegisterNodeRPCCommands,g' $(git grep -l RegisterMiscRPCCommands)
-END VERIFY SCRIPT-

fa758f9bc5

MarcoFalke added the label Refactoring on May 3, 2022
MarcoFalke added the label RPC/REST/ZMQ on May 3, 2022
DrahtBot commented at 3:49 PM on May 3, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24162 (rpc: add require_checksum flag to deriveaddresses by kallewoof)
- #24161 (rpc/doc: describe using combo(privkey) to get checksum and then list … by kallewoof)
- #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
pk-b2 commented at 6:38 PM on May 3, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/25058/commits/fa758f9bc5e3a9a4653d7779a6a17adb8e51e92c

Testing: Built locally, verified RPCs are still working

Agree with the renaming to rpc/node.cpp
vincenzopalazzo approved
vincenzopalazzo commented at 8:22 PM on May 3, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/25058/commits/fa758f9bc5e3a9a4653d7779a6a17adb8e51e92c
fanquake merged this on May 4, 2022
fanquake closed this on May 4, 2022
MarcoFalke deleted the branch on May 4, 2022
sidhujag referenced this in commit 4f2eae7d93 on May 4, 2022
DrahtBot locked this on May 4, 2023

Contributors

Labels

Refactoring RPC/REST/ZMQ

rpc: Move output script RPCs to separate file, rename misc.cpp #25058

Conflicts