blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time #25060

1. 
   jonatack commented at 8:52 pm on May 3, 2022: member

   Suggested in #25016 (review), the lifetimebound attribute here indicates that a resource owned by the start_block param of CBlockIndex* BlockManager::GetFirstStoredBlock() can be retained by the method’s return value, which enables detecting the use of out-of-scope stack memory (ASan stack-use-after-scope) at compile time.

   See https://releases.llvm.org/12.0.0/tools/clang/docs/AttributeReference.html#lifetimebound and #22278 for related discussion, and #25040 for a similar example.

2. blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time

   See PR 22278 for discussion.
   
   Co-authored-by: MarcoFalke <falke.marco@gmail.com>

   4cb9d21434
3. DrahtBot added the label Block storage on May 3, 2022
4. 
   MarcoFalke commented at 9:01 am on May 4, 2022: member

   review ACK 4cb9d214345550cb0299139b2badb73ba1e53532
5. MarcoFalke merged this on May 4, 2022
6. MarcoFalke closed this on May 4, 2022

   ---

7. jonatack deleted the branch on May 4, 2022
8. sidhujag referenced this in commit cedc09f1e9 on May 4, 2022
9. MarcoFalke referenced this in commit f821fc9813 on Sep 1, 2022
10. sidhujag referenced this in commit 502389d546 on Sep 1, 2022
11. DrahtBot locked this on May 4, 2023

Contributors
jonatack MarcoFalke

Labels
Block storage