test: previous releases: add v23.0 #25063

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2022/05/add_previous_release changing 4 files +20 −6

Sjors commented at 2:54 PM on May 4, 2022: member

Follows the same pattern as d8b705f1caeb3b4a6790cb26e4e5584ca791d965 (v22.0) and 8a57a06a5062dd8dfdefca4e404d0ddbd2a3da1d (v0.21.0).

Starting from v23.0 there is a separate macOS release for x86_64 and aarch64.
fanquake added the label Tests on May 4, 2022

in test/get_previous_releases.py:109 in b395bb601d outdated

 104 | @@ -96,8 +105,11 @@ def download_binary(tag, args) -> int:
 105 |      if match:
 106 |          bin_path = 'bin/bitcoin-core-{}/test.{}'.format(
 107 |              match.group(1), match.group(2))
 108 | +    platform = args.platform
 109 | +    if float(tag[1:]) < 23 and (platform == "x86_64-apple-darwin" or platform == "aarch64-apple-darwin"):

prusnak commented at 8:46 PM on May 4, 2022:

The comparison float(tag[1:]) < 23 looks ugly ... doesn't it break when tag is e.g. "v0.21.0"?

I think the simple tag < "v23" or tag[1:] < "23" does the trick, no?

Also this is Python so we can use platform in ...

    if tag < "v23" and platform in ["x86_64-apple-darwin", "aarch64-apple-darwin"]:

Sjors commented at 8:01 AM on May 6, 2022:

Done!

prusnak changes_requested

test: previous releases: add v23.0

Starting from v23.0 there is a separate macOS release for x86_64 and aarch64.

Co-authored-by: Pavol Rusnak <pavol@rusnak.io>

dba1231672

Sjors force-pushed on May 6, 2022
prusnak approved
prusnak commented at 9:03 AM on May 6, 2022: contributor

Approach ACK dba123167236a172d2d33861d58aa94a19729671
MarcoFalke merged this on May 6, 2022
MarcoFalke closed this on May 6, 2022
Sjors deleted the branch on May 6, 2022
DrahtBot locked this on May 6, 2023

Contributors

Sjors

prusnak

Labels

Tests