The included header is thousand lines of template code (not counting the recursive includes) for basically one function.
Wrap boost::replace_all #25068
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2205-util-string-📉 changing 8 files +22 −19-
MarcoFalke commented at 2:37 PM on May 5, 2022: member
- MarcoFalke added the label Refactoring on May 5, 2022
-
hebasto commented at 2:38 PM on May 5, 2022: member
Concept ACK.
-
laanwj commented at 3:20 PM on May 5, 2022: member
Concept ACK, good idea to wrap or pimpl as much of boost as possible, to avoid huge amount of headers code being compiled for everything.
-
theStack commented at 5:14 PM on May 5, 2022: member
Concept ACK
-
pk-b2 commented at 6:24 PM on May 5, 2022: none
Concept ACK
There is one more instance of boost:replace_all in https://github.com/bitcoin/bitcoin/blob/fa7734d7e7e52ec9557c9508d6be164025ff90d7/src/util/system.cpp#L1255
- MarcoFalke force-pushed on May 5, 2022
-
Wrap boost::replace_all fa2deae2a8
- MarcoFalke force-pushed on May 5, 2022
-
pk-b2 commented at 6:56 PM on May 5, 2022: none
-
w0xlt commented at 6:57 PM on May 5, 2022: contributor
Approach ACK
-
seejee commented at 7:13 PM on May 5, 2022: contributor
-
martinus commented at 6:27 AM on May 6, 2022: contributor
ACK fa2deae2a86417d7e0d4cd33fb933b1000d20313. Next step, replace with custom implementation to get rid of another boost header?
nit: string.cpp shows
Copyright (c) 2019 The Bitcoin Core developers - MarcoFalke merged this on May 6, 2022
- MarcoFalke closed this on May 6, 2022
- MarcoFalke deleted the branch on May 6, 2022
- sidhujag referenced this in commit c07deba2bf on May 9, 2022
- kittywhiskers referenced this in commit 97825d70e6 on Dec 21, 2022
- kittywhiskers referenced this in commit e5a39de842 on Dec 26, 2022
- kittywhiskers referenced this in commit 6eb19f7ec9 on Jan 3, 2023
- kittywhiskers referenced this in commit 58371f7753 on Jan 13, 2023
- kittywhiskers referenced this in commit 9141046377 on Jan 15, 2023
- kittywhiskers referenced this in commit 0bd538bc40 on Jan 19, 2023
- PastaPastaPasta referenced this in commit 2d7a448fdc on Jan 19, 2023
- Fabcien referenced this in commit 3409b420ba on Mar 6, 2023
- DrahtBot locked this on May 6, 2023
Labels