Wallet: Ensure m_attaching_chain is set before registering for signals #25088

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_wallet_race_attachingbb changing 1 files +2 −1
  1. luke-jr commented at 1:55 AM on May 9, 2022: member

    Avoids a race where chainStateFlushed could be called before rescanning began, yet rescan gets interrupted or fails

    Followup for #24984 avoiding a race between registering and setting the flag.

  2. Wallet: Ensure m_attaching_chain is set before registering for signals
    Avoids a race where chainStateFlushed could be called before rescanning began, yet rescan gets interrupted or fails
    ba10b90915
  3. ramsemune123 approved
  4. DrahtBot added the label Wallet on May 9, 2022
  5. fanquake deleted a comment on May 9, 2022
  6. mzumsande commented at 8:20 PM on May 9, 2022: member

    Code Review ACK ba10b90915dae6a802ecb0f80f72a1a9ea5a4c67

    I agree that this is avoids the possibility of a race.

  7. fanquake requested review from achow101 on May 9, 2022
  8. achow101 commented at 7:28 PM on May 16, 2022: member

    ACK ba10b90915dae6a802ecb0f80f72a1a9ea5a4c67

  9. achow101 merged this on May 16, 2022
  10. achow101 closed this on May 16, 2022

  11. luke-jr referenced this in commit 8fc36e243a on May 21, 2022
  12. sidhujag referenced this in commit 889921789f on May 28, 2022
  13. DrahtBot locked this on May 16, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me