There is already mockscheduler, so it seems brittle, confusing and redundant to be able to mock the scheduler by adjusting the system clock.
Switch scheduler to steady_clock #25100
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2205-sched_stead-🚵 changing 3 files +27 −27-
MarcoFalke commented at 9:00 AM on May 10, 2022: member
-
Switch scheduler to steady_clock fa90516422
- MarcoFalke added the label Refactoring on May 10, 2022
-
jonatack commented at 9:15 AM on May 10, 2022: member
Concept ACK
-
laanwj commented at 9:24 AM on May 10, 2022: member
Concept ACK, this is a classic usecase for steady_clock.
I don't think it's purely a refactor though.
- MarcoFalke removed the label Refactoring on May 10, 2022
- MarcoFalke added the label Utils/log/libs on May 10, 2022
-
w0xlt commented at 10:03 AM on May 10, 2022: contributor
Concept ACK
-
laanwj commented at 12:25 PM on May 10, 2022: member
Code review ACK fa9051642269f62f560af3f323fbf36cb7b58082
- w0xlt approved
-
w0xlt commented at 1:12 PM on May 10, 2022: contributor
-
sipa commented at 1:40 PM on May 10, 2022: member
Concept ACK
-
DrahtBot commented at 7:25 PM on May 10, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24931 (Strengthen thread safety assertions by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke merged this on May 11, 2022
- MarcoFalke closed this on May 11, 2022
- MarcoFalke deleted the branch on May 11, 2022
- sidhujag referenced this in commit 1c410b9e16 on May 11, 2022
- Fabcien referenced this in commit 2fa1cd8408 on Sep 29, 2022
- DrahtBot locked this on May 11, 2023
Labels