Seems confusing to have this helper when it is possible to get the system time in a type-safe way by simply calling std::chrono::system_clock::now (C++11).
This patch replaces GetTimeSeconds and removes it:
bitcoin-cli.cpp by system_clocktest/fuzz/fuzz.cpp by steady_clock
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
438 | @@ -433,7 +439,7 @@ class NetinfoRequestHandler : public BaseRequestHandler 439 | if (conn_type == "addr-fetch") return "addr"; 440 | return ""; 441 | } 442 | - const int64_t m_time_now{GetTimeSeconds()}; 443 | + const int64_t m_time_now{CountSeconds(Now<CliSeconds>())};
As this is used solely to measure intervals, it may be another good use for steady_clock.
Oh, never mind, it compares to the server time.
36 | +template <typename Clock> 37 | +constexpr int64_t CountSeconds(std::chrono::time_point<Clock, std::chrono::seconds> t) 38 | +{ 39 | + return t.time_since_epoch().count(); 40 | +} 41 | constexpr int64_t count_seconds(std::chrono::seconds t) { return t.count(); }
It's confusing to me to have both count_seconds and CountSeconds.
Ah, I forgot that function overloading exists. Thanks, fixed.
Code review ACK fab9e8a29c2cdeab6cf1ae7c1fc0e0a3af783b17
ACK fab9e8a29c2cdeab6cf1ae7c1fc0e0a3af783b17
