rpc: remove deprecated "softforks" field from getblockchaininfo #25114

pull theStack wants to merge 2 commits into bitcoin:master from theStack:202205-rpc-remove_deprecated_softforks_from_getblockchaininfo changing 2 files +4 −17

theStack commented at 12:23 PM on May 12, 2022: member

Information on soft fork status has been moved from the getblockchaininfo RPC to the getdeploymentinfo RPC in #23508. The "softfork" result in getblockchaininfo was still available for 23.0 with the -deprecatedrpc=softforks configuration option, but this can be fully removed now for the next release (24.0).
DrahtBot added the label RPC/REST/ZMQ on May 12, 2022
brunoerg commented at 12:36 PM on May 12, 2022: member

Concept ACK
DrahtBot added the label Needs rebase on May 13, 2022
rpc: remove deprecated "softforks" field from getblockchaininfo 8c5533c7a9
doc: add release notes about removal of the `deprecatedrpc=softforks` flag a01b92ad86
theStack force-pushed on May 13, 2022
theStack commented at 9:50 AM on May 13, 2022: member

Rebased on master.
DrahtBot removed the label Needs rebase on May 13, 2022
shaavan approved
shaavan commented at 2:18 PM on May 16, 2022: contributor
ACK a01b92ad8672dcf4369ee9cf36a6b0157d73786c
- I agree with removing the “softfork” field, which was deprecated in v23.0 from the getblockchaininfo RPC output in v24.0.
- The code changes look clean and are complete. I was able to compile the Bitcoin core successfully.
- The added release notes documentation documents the changes done in this PR and explains properly where a user must look if searching for the softfork field.
I am adding a few screenshots to show the proper working of this PR.
- getblockchainfo RPC works correctly:
- getblockchaininfo fails when --deprecatedrpc=softforks is used
- getdeploymentinfo RPC works correctly.

in doc/release-notes.md:56 in a01b92ad86

  49 | @@ -50,6 +50,10 @@ P2P and network changes
  50 |  Updated RPCs
  51 |  ------------
  52 |  
  53 | +- The `-deprecatedrpc=softforks` configuration option has been removed.  The
  54 | +  RPC `getblockchaininfo` no longer returns the `softforks` field, which was
  55 | +  previously deprecated in 23.0. (#23508) Information on soft fork status is
  56 | +  now only available via the `getdeploymentinfo` RPC.

ajtowns commented at 8:14 PM on May 16, 2022:

Should reference this PR? ie .... RPC. (#25114)

ajtowns commented at 8:15 PM on May 16, 2022: member

ACK a01b92ad8672dcf4369ee9cf36a6b0157d73786c
ajtowns commented at 8:18 PM on May 16, 2022: member

@shaavan "getblockchaininfo fails when --deprecatedrpc=softforks is used" -- the -deprecatedrpc=softforks flag should be passed to bitcoind, not bitcoin-cli
MarcoFalke merged this on May 17, 2022
MarcoFalke closed this on May 17, 2022
theStack deleted the branch on May 17, 2022
sidhujag referenced this in commit c64b45dc82 on May 28, 2022
Roasbeef referenced this in commit fabf989e5e on Aug 5, 2022
Roasbeef referenced this in commit 592af654d0 on Aug 5, 2022
Roasbeef referenced this in commit 3a37ef3cb8 on Aug 5, 2022
Roasbeef referenced this in commit 0718e5d6ee on Aug 6, 2022
Roasbeef referenced this in commit 492f8b6999 on Aug 6, 2022
Roasbeef referenced this in commit deeaa0c9c7 on Aug 13, 2022
DrahtBot locked this on May 17, 2023

Contributors

Labels

Linked (view graph)

#23508 Add getdeploymentinfo RPC