refactor: Remove `NO_THREAD_SAFETY_ANALYSIS` from non-test/benchmarking code #25148

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:220516-todo changing 6 files +44 −33
  1. hebasto commented at 6:55 PM on May 16, 2022: member

    In non-test/benchmarking code, there are three cases of the NO_THREAD_SAFETY_ANALYSIS annotation which are accompanied with TODO comments.

    This PR adds proper thread safety annotations instead of NO_THREAD_SAFETY_ANALYSIS.

  2. Add proper thread safety annotation to `CachedTxGetAvailableCredit()` ca446f2c59
  3. Add proper thread safety annotation to `CWallet::GetTxConflicts()` 8cfe93e3fc
  4. Add more proper thread safety annotations a55db4ea1c
  5. DrahtBot commented at 7:33 PM on May 16, 2022: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23507 (Refactor: Improve API design of ScriptToUniv, TxToUniv etc to return the UniValue instead of mutating a parameter/reference by mjdietzx)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. DrahtBot added the label Refactoring on May 16, 2022
  7. DrahtBot added the label RPC/REST/ZMQ on May 16, 2022
  8. DrahtBot added the label Wallet on May 16, 2022
  9. jonatack commented at 7:53 AM on May 18, 2022: member

    Concept ACK, good idea.

  10. laanwj commented at 8:09 AM on May 18, 2022: member

    LGTM Code review ACK a55db4ea1cf10e0ab4a6eb5cd1dd3bd95626fba0

  11. MarcoFalke merged this on May 18, 2022
  12. MarcoFalke closed this on May 18, 2022
  14. hebasto deleted the branch on May 18, 2022
  15. sidhujag referenced this in commit 834bdd1270 on May 28, 2022
  16. Fabcien referenced this in commit 62b61aba6a on Dec 8, 2022
  17. DrahtBot locked this on May 18, 2023
Contributors
hebastoDrahtBotjonatacklaanwjw0xlt
Labels
RefactoringWalletRPC/REST/ZMQ
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me