This probably makes no large difference, as the setting is already enabled by default in the functional tests. However, I think it is nice to also enable it in debug builds by default to catch issues while manually testing without the runtime flags specified.
build: Enable RPC_DOC_CHECK on --enable-debug #25170
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2205-enable-rpc-doc-check-on-debug-🗿 changing 2 files +8 −1-
MarcoFalke commented at 6:00 AM on May 19, 2022: member
-
build: Enable RPC_DOC_CHECK on --enable-debug fafae678f6
-
MarcoFalke commented at 6:01 AM on May 19, 2022: member
Can be tested by running (for example):
$ ./src/bitcoind -? -help-debug|grep -A3 rpcdoc - DrahtBot added the label Build system on May 19, 2022
- DrahtBot added the label RPC/REST/ZMQ on May 19, 2022
- vincenzopalazzo approved
-
vincenzopalazzo commented at 1:36 PM on May 19, 2022: none
-
DrahtBot commented at 3:09 PM on May 19, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24757 (build, ci: add
DEBUG_LOCKCONTENTIONto --enable-debug and CI by jonatack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- #24757 (build, ci: add
- fanquake merged this on May 20, 2022
- fanquake closed this on May 20, 2022
-
- MarcoFalke deleted the branch on May 20, 2022
- sidhujag referenced this in commit 84a4c6614a on May 28, 2022
- DrahtBot locked this on May 20, 2023
