test: add coverage for unknown network in -onlynet #25173

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-05-unknown-onlynet changing 1 files +6 −0

brunoerg commented at 8:11 PM on May 19, 2022: member

This PR adds test coverage for the following init error by passing an unknown network in -onlynet https://github.com/bitcoin/bitcoin/blob/0de36941eca1bff91420dd878eb097db2b1a596c/src/init.cpp#L1311
jonatack commented at 8:23 PM on May 19, 2022: member

Concept ACK, this case looks to be untested.

in test/functional/feature_proxy.py:353 in e9d32dd8dd outdated

 349 | @@ -349,6 +350,11 @@ def networks_dict(d):
 350 |              self.nodes[1].extra_args = ["-onlynet=onion", arg]
 351 |              self.nodes[1].assert_start_raises_init_error(expected_msg=msg)
 352 |  
 353 | +        self.log.info("Test passing unknown network in -onlynet raises expected init error")

jonatack commented at 8:28 PM on May 19, 2022:

        self.log.info("Test passing unknown network to -onlynet raises expected init error")

brunoerg commented at 9:40 PM on May 19, 2022:

done!

jonatack commented at 8:29 PM on May 19, 2022: member

ACK e9d32dd8dd3c1a2cc42603a792638afe3e170482
DrahtBot added the label Tests on May 19, 2022
test: add coverage for unknown network in -onlynet 055d94d1ab
brunoerg force-pushed on May 19, 2022
MarcoFalke commented at 7:16 AM on May 20, 2022: member

rACK 055d94d1ab4937ed0080459fbe63568dc47b6786
MarcoFalke merged this on May 20, 2022
MarcoFalke closed this on May 20, 2022
jonatack commented at 7:41 AM on May 20, 2022: member

Post-merge re-ACK
sidhujag referenced this in commit a60703b27f on May 28, 2022
DrahtBot locked this on May 20, 2023

Contributors

Labels