doc: remove misleading AreInputsStandard() comment #25210

pull jamesob wants to merge 1 commits into bitcoin:master from jamesob:2022-05-areinputsstandard-comment changing 1 files +0 −1

jamesob commented at 12:05 PM on May 25, 2022: member

This check isn't any longer just about bad pay-to-script-hash inputs; it also excludes any kind of nonstandard input, unknown witness versions, coinbases, etc.

doc: remove misleading AreInputsStandard() comment

This check isn't any longer just about bad pay-to-script-hash inputs; it
also excludes any kind of nonstandard input, unknown witness versions,
coinbases, etc.

be6d4315c1

fanquake added the label Docs on May 25, 2022
in src/validation.cpp:817 in be6d4315c1
```
 813 | @@ -814,7 +814,6 @@ bool MemPoolAccept::PreChecks(ATMPArgs& args, Workspace& ws)
 814 |          return false; // state filled in by CheckTxInputs
 815 |      }
 816 |  
 817 | -    // Check for non-standard pay-to-script-hash in inputs
```
dunxen commented at 5:34 PM on May 25, 2022:

Could we just make this // Check for non-standard inputs instead of removing entirely? Just for consistency like below for witnesses. I suppose AreInputsStandard() is self-documented anyway so I can understand the want to remove it.

laanwj commented at 7:02 AM on May 26, 2022:

I'm fine with removing it in this case. In contrast to a lot of code "fRequireStandard && !AreInputsStandard(tx, m_view)" looks very self-documenting to me, maybe "Check for non-standard inputs" wouldn't add anything?
DrahtBot commented at 6:09 PM on May 25, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #13525 (policy: Report reason inputs are nonstandard from AreInputsStandard by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj commented at 7:04 AM on May 26, 2022: member

ACK be6d4315c150646cf672778e9232f086403e95df
dunxen approved
dunxen commented at 8:52 AM on May 26, 2022: contributor

ACK be6d431
jonatack commented at 9:39 AM on May 26, 2022: member

ACK be6d4315c150646cf672778e9232f086403e95df
laanwj merged this on May 26, 2022
laanwj closed this on May 26, 2022
sidhujag referenced this in commit 797b88a2d5 on May 28, 2022
DrahtBot locked this on May 26, 2023

Contributors

Labels

doc: remove misleading AreInputsStandard() comment #25210

Conflicts