new splash screen #2524

jonasschnelli commented at 9:44 AM on April 14, 2013: contributor

why:

the current splash-screen has no referring to official images on - https://en.bitcoin.it/wiki/Promotional_graphics
the current splash screen only exists in a low res jpg
current splash screen looks dark and "hackish"
new splash screen should generate positive, "trust-emotions".
new splash screen gives the user infos about the running client.
new splash screen can handle long messages (in a lot of - languages the text is cropped in current release)
new size (x2) 400x312
contains textual information about the client
textinfos are dynamicly written to the pixmap

when -testnet is switch on, the splashscreen will show the bitcoin logo in testnet-color (as well as a text [testnet])

example: https://dl.dropbox.com/u/7383846/new_bitcoin_splash.png

sipa commented at 9:55 AM on April 14, 2013: member

It looks like this for me: http://bitcoin.sipa.be/splash.png

The image is nice, but is it intended that the text overlaps with the '(B)'?

BitcoinPullTester commented at 10:19 AM on April 14, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/cd6c4e6b2c621ccc0c05fd837d8c56a3a0c3481d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj commented at 10:34 AM on April 14, 2013: member

There's an interesting unicode character in there :) splash

in src/qt/splashscreen.cpp:None in cd6c4e6b2c outdated

  15 | +    int titleCopyrightVSpace    = 40;
  16 | +
  17 | +    // define text to place
  18 | +    QString titleText       = QString(QApplication::applicationName()).replace(QString("-testnet"), QString(""), Qt::CaseSensitive); // cut of testnet, place it as single object further down
  19 | +    QString versionText     = QString("Version %1").arg(QString::fromStdString(FormatFullVersion()));
  20 | +    QString copyrightText   = QChar(0xA9)+QString(" 2009-%1\n").arg(COPYRIGHT_YEAR) + QString(tr("The Bitcoin developers"));

laanwj commented at 10:40 AM on April 14, 2013:

Seems the \n doesn't work here? It is rendered as a glyph instead of treated as a new line. Maybe there is some QTextOption that can be used to change this.

Diapolo commented at 2:07 PM on April 14, 2013:

Easiest way would be to use another QString for the next line :).

jonasschnelli commented at 11:58 AM on April 14, 2013: contributor

Okay. I would had been to nice to have no platform differences on font rendering. :) Let me adjust some things and it then probably needs a re-test on your side. Because get the toolchain and build process running on my win/linux vm is currently not possible. But should all be fixable (remove \n, remove "Helvetica" and take Arial instead.).

in src/qt/splashscreen.cpp:None in cd6c4e6b2c outdated

   0 | @@ -0,0 +1,69 @@
   1 | +#include "splashscreen.h"
   2 | +#include "clientversion.h"
   3 | +#include "util.h"
   4 | +
   5 | +#include <QPainter>
   6 | +#include <QApplication>

Diapolo commented at 2:14 PM on April 14, 2013:

Are you using this patch with Qt5 already? I'm just asking because I needed to make that include in some files the top-most one, to get our code compile with Qt5 :).

jonasschnelli commented at 7:31 PM on April 14, 2013:

Qt5 should work. Most code lines i did under Qt5 (your branch). Yesterday i had to compile Qt 4.8.4 on mac to get it also running on master/Qt4.8 (compile took ~4h). So it should work on both. Maybe the #include fix is missing.

Diapolo commented at 7:39 PM on April 14, 2013:

If this is working for you, you don't need to change anything here :).

laanwj commented at 2:43 PM on April 14, 2013: member

Hm it should be possible to get roughly the same font on all platforms by specifying multiple font names.

jonasschnelli commented at 7:46 PM on April 14, 2013: contributor

I just changes to "Arial" and fixed the newline issue. Can someone retest on linux and win?

This is how it looks an my mac (retina - 10.8) with Qt4.8.4:

Bildschirmfoto 2013-04-14 um 21 43 00

in src/qt/splashscreen.cpp:None in 1e5edc7b7e outdated

  18 | +    QString titleText       = QString(QApplication::applicationName()).replace(QString("-testnet"), QString(""), Qt::CaseSensitive); // cut of testnet, place it as single object further down
  19 | +    QString versionText     = QString("Version %1").arg(QString::fromStdString(FormatFullVersion()));
  20 | +    QString copyrightText   = QChar(0xA9)+QString(" 2009-%1 ").arg(COPYRIGHT_YEAR) + QString(tr("The Bitcoin developers"));
  21 | +    QString testnetAddText  = QString(tr("[testnet]")); // define text to place as single text object
  22 | +
  23 | +    const char *font        = "Arial";

Diapolo commented at 8:30 PM on April 14, 2013:

This could be a QString, right?

jonasschnelli commented at 8:33 PM on April 14, 2013:

Ah. Yes. Had it as const char* befor moving to a separate variable. But yes. It should be a QString. Will change it in the next mins (amend).

Diapolo commented at 8:30 PM on April 14, 2013: none

That is really looking beautiful :)!

burger2 commented at 10:01 PM on April 14, 2013: contributor

Nice changes!!!

laanwj commented at 5:29 PM on April 15, 2013: member

Looks good now. However I do not see any progress messages (such as "Verifying wallet...") with the new splash screen. Is this also a Linux specific problem?

BitcoinPullTester commented at 1:27 AM on April 16, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1e5edc7b7e8e8416bc0ba123bd282d8e791bf184 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

jonasschnelli commented at 7:57 AM on April 16, 2013: contributor

@laanwj strange. The messages is written by a standard QT command: QSplashScreen::showMessage(QString::fromStdString(message), Qt::AlignBottom|Qt::AlignHCenter, QColor(55,55,55));

Let me install the toolchain/src on my ubuntu vm and try to debug it..

laanwj commented at 8:55 AM on April 16, 2013: member

I'll also try to debug it

new splash screen

why:

- the current splash-screen has no referring to official images on - https://en.bitcoin.it/wiki/Promotional_graphics
- the current splash screen only exists in a low res jpg
- current splash screen looks dark and "hackish"
- new splash screen should generate positive, "trust-emotions".
- new splash screen gives the user infos about the running client.
- new splash screen can handle long messages (in a lot of - languages the text is cropped in current release)

- new size (x2) 400x312

- contains textual information about the client
- textinfos are dynamicly written to the pixmap

when -testnet is switch on, the splashscreen will show the bitcoin logo in testnet-color (as well as a text [testnet])

example: https://dl.dropbox.com/u/7383846/new_bitcoin_splash.png

f9124587cc

jonasschnelli commented at 8:20 AM on April 17, 2013: contributor

@laanwj found the problem source. Ubuntu has no Arial and has also different font rendering. I did update the code so now, the font-size will be increased with factor 0.75 when the calculated text width goes over 160px (which would mean it then would go over the "B" in the splashscreen). Works for mac and linux (ubuntu). How about windows?

The missing status text at the bottom was my fault. Did not update the textcolor. Now fixed.

BitcoinPullTester commented at 8:44 AM on April 17, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f9124587ccea723dbd743e3877a7071fbb6c5732 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj commented at 1:44 PM on April 17, 2013: member

ACK

testnetsplash

laanwj referenced this in commit 52ae314b5e on Apr 18, 2013

laanwj merged this on Apr 18, 2013

laanwj closed this on Apr 18, 2013

laudney referenced this in commit 1abca027e1 on Mar 19, 2014

DrahtBot locked this on Sep 8, 2021