CVE-2021-31876 child transactions do not inherit rbf signaling #25252

issue instagibbs opened this issue on May 30, 2022

instagibbs commented at 7:20 PM on May 30, 2022: member

The original issue reported at https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-May/018893.html and at https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-31876 seems to be unresolved in the codebase, and there are no open issues to track this, so I'm opening one.
instagibbs added the label Bug on May 30, 2022
MarcoFalke commented at 7:20 AM on May 31, 2022: member

Have you seen #22209 ?
MarcoFalke commented at 7:23 AM on May 31, 2022: member

Also, there is both a test for this (https://github.com/bitcoin/bitcoin/pull/22210) and documentation (https://github.com/bitcoin/bitcoin/pull/21946), so I am pretty sure this issue can be closed?
ghost commented at 1:03 PM on May 31, 2022: none

The original issue reported at https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-May/018893.html and at https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-31876 seems to be unresolved in the codebase, and there are no open issues to track this, so I'm opening one.

Are the downstream projects still not aware of the default RBF policy implemented in bitcoin core? Particularly after #21946 that MarcoFalke shared
instagibbs commented at 2:09 PM on May 31, 2022: member

I don't think issues should be closed unless this is a wont-fix situation...?
MarcoFalke commented at 2:12 PM on May 31, 2022: member

How is it not a duplicate of #22209 ?
instagibbs commented at 2:15 PM on May 31, 2022: member

misread my thread of emails as I woke, it is
instagibbs closed this on May 31, 2022
instagibbs commented at 2:31 PM on May 31, 2022: member

well technically, the issue you linked is claiming the issue is that getmempoolentry is correctly identifying bip125 replaceability as per spec, we should make sure we track the issue that we're not actually conforming...
MarcoFalke commented at 2:37 PM on May 31, 2022: member

Happy to change the title or description if you have suggestions?
instagibbs commented at 2:42 PM on May 31, 2022: member

as long as the issue isn't closed until we fix inherited signaling or decide we won't fix, it's fine, thanks
DrahtBot locked this on May 31, 2023

Contributors

Labels