This PR adds test coverage for the following init error: https://github.com/bitcoin/bitcoin/blob/b9ef5a10e2fa4609d048db57b99463305455ebe4/src/init.cpp#L917-L919
Passing a non-hex value to -minimumchainwork should throw an initial error.
test: add coverage for non-hex value to -minimumchainwork #25253
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-05-minimumchainwork-nonhex changing 1 files +8 −0-
brunoerg commented at 8:55 PM on May 30, 2022: member
- fanquake added the label Tests on May 30, 2022
-
w0xlt commented at 9:56 PM on May 30, 2022: contributor
Approach ACK
- kristapsk approved
-
kristapsk commented at 10:21 PM on May 30, 2022: contributor
ACK 49fe179f00f2ffa1eb96b7737b6b07c92dc5e865
-
DrahtBot commented at 4:09 AM on May 31, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24178 (p2p: Respond to getheaders if we have sufficient chainwork by sdaftuar)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Needs rebase on May 31, 2022
-
test: add coverage for non-hex value to -minimumchainwork ebfc308ea4
- brunoerg force-pushed on May 31, 2022
-
brunoerg commented at 11:25 AM on May 31, 2022: member
Rebased
- kristapsk approved
-
kristapsk commented at 11:41 AM on May 31, 2022: contributor
re-ACK ebfc308ea4b8851118e8194d837556bf443c329c
-
laanwj commented at 12:07 PM on May 31, 2022: member
Code review ACK ebfc308ea4b8851118e8194d837556bf443c329c
- DrahtBot removed the label Needs rebase on May 31, 2022
- MarcoFalke merged this on May 31, 2022
- MarcoFalke closed this on May 31, 2022
- sidhujag referenced this in commit a5568b11db on May 31, 2022
- DrahtBot locked this on May 31, 2023
