test: Set maxfeerate=0 in MiniWallet sendrawtransaction() #25262

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2206-test-mini-fast-📨 changing 2 files +4 −4

MarcoFalke commented at 3:09 PM on June 1, 2022: member

It should be safe to set, because MiniWallet will only ever deal with test transactions, so loss-of-funds is not a reason to keep the feerate check.

It is beneficial to set, as it makes tests less verbose to write. Also, it may speed up tests, as the fee-check can be skipped: #25087 (review)
test: Set maxfeerate=0 in MiniWallet sendrawtransaction() fafaad98f7
fanquake added the label Tests on Jun 1, 2022
fanquake requested review from theStack on Jun 1, 2022
michaelfolkson commented at 3:59 PM on June 1, 2022: contributor

Concept ACK, Approach ACK

Leaving other tests (e.g. feature_dbcrash.py) that use MiniWallet and have a maxfeerate check for a follow up PR? Or include in this PR?
MarcoFalke commented at 4:05 PM on June 1, 2022: member

I think I covered all cases. Can you point to a line where MiniWallet::sendrawtransaction is called that passes the option?
theStack approved
theStack commented at 4:07 PM on June 1, 2022: member

Code-review ACK fafaad98f785d763848c546d096e6738d507709e

Leaving other tests (e.g. feature_dbcrash.py) that use MiniWallet and have a maxfeerate check for a follow up PR? Or include in this PR?

Note that other tests that pass the maxfeerate parameter explicitly directly call the node's sendrawtransaction RPC (e.g. self.nodes[0].sendrawtransaction(...)), not the MiniWallet method with the same name. This PR tackles all instances of MiniWallet.sendrawtransaction (verified that the two in mempool_accept.py are the only ones).
michaelfolkson commented at 4:14 PM on June 1, 2022: contributor

Sorry for the noise

ACK fafaad98f785d763848c546d096e6738d507709e
MarcoFalke commented at 6:17 PM on June 1, 2022: member

Sure, no worries.
MarcoFalke merged this on Jun 1, 2022
MarcoFalke closed this on Jun 1, 2022
MarcoFalke deleted the branch on Jun 1, 2022
sidhujag referenced this in commit 72ad43cbf4 on Jun 2, 2022
DrahtBot locked this on Jun 1, 2023

Contributors

Labels

Linked (view graph)

#25087 test: use MiniWallet for feature_dbcrash.py