This PR adds missing test coverage for the createrawtransaction RPC, in the case that the replaceable parameter is set, but the passed transaction doesn't signal RBF (i.e. no input's nSequence is < 0xffffffe):
https://github.com/bitcoin/bitcoin/blob/1c7ef0abd11f35a27cc860ceb7e075b78f53cecf/src/rpc/rawtransaction_util.cpp#L135-L137
test: check `replaceable` mismatch error in `createrawtransaction` RPC #25267
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202206-test-check_rbf_mismatch_in_createrawtransaction changing 1 files +5 −0-
theStack commented at 11:05 AM on June 2, 2022: member
-
test: check `replaceable` mismatch error in `createrawtransaction` RPC 1bace0cfee
- DrahtBot added the label Tests on Jun 2, 2022
- brunoerg approved
-
brunoerg commented at 12:30 PM on June 2, 2022: member
crACK 1bace0cfeef35c4413769474173a692093a046f3
- furszy approved
-
furszy commented at 2:59 PM on June 2, 2022: member
Code review ACK 1bace0cf
-
laanwj commented at 5:59 PM on June 2, 2022: member
Code review ACK 1bace0cfeef35c4413769474173a692093a046f3
- laanwj merged this on Jun 2, 2022
- laanwj closed this on Jun 2, 2022
- theStack deleted the branch on Jun 2, 2022
- sidhujag referenced this in commit 81f9d3a062 on Jun 3, 2022
- DrahtBot locked this on Jun 2, 2023