This makes it easier to verify that the entries in these two long lists (P2P message names) correspond correctly. Also, it's easier to add new entries and reduces source code line count. No functional change.
[refactor] use ITEMS macro to unify NetMsgType, allNetMessageTypes lists #25275
pull LarryRuane wants to merge 1 commits into bitcoin:master from LarryRuane:2022-06-ITEMS-macro changing 1 files +47 −68-
LarryRuane commented at 6:51 PM on June 4, 2022: contributor
-
d6198105a9
[refactor] use ITEMS macro to unify NetMsgType, allNetMessageTypes lists
This makes it easier to verify that the entries in these two long lists (P2P message names) correspond correctly. Also, it's easier to add new entries and reduces source code line count. No functional change.
- DrahtBot added the label P2P on Jun 4, 2022
-
DrahtBot commented at 5:22 AM on June 5, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #23233 (BIP324: Add encrypted p2p transport {de}serializer by dhruv)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
laanwj commented at 5:29 PM on June 8, 2022: member
~0 on this, I appreciate the idea to have the information in one list, but I like to avoid C macros and clever tricks with them where possible, due to the kludgy syntax
- LarryRuane closed this on Jul 25, 2022
- bitcoin locked this on Jul 25, 2023
Contributors
Labels