test: passing a value below 5 MB to -maxmempool should throw an error #25358

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-06-test-minimum-maxmempool changing 1 files +4 −0

brunoerg commented at 1:01 PM on June 13, 2022: member

This PR adds test coverage for the following init error: https://github.com/bitcoin/bitcoin/blob/5174a139c92c1238f9700d06e362dc628d81a0a9/src/init.cpp#L931-L935

By default, the minimum value is 5 MB. See: https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-memory.md#memory-pool
test: passing a value below 5 MB to -maxmempool should throw an error 216c9b00ec
fanquake added the label Tests on Jun 13, 2022
laanwj commented at 1:44 PM on June 15, 2022: member

Code review ACK 216c9b00ec6f8dca815fa5a308abaf4c34674b41
furszy approved
furszy commented at 1:55 PM on June 15, 2022: member

Code review ACK 216c9b00

Min mempool value is actually 4,040,000 bytes.
MarcoFalke merged this on Jun 15, 2022
MarcoFalke closed this on Jun 15, 2022
sidhujag referenced this in commit c2b4653531 on Jun 15, 2022
DrahtBot locked this on Jun 15, 2023

Contributors

Labels