test: remove unused `create_confirmed_utxos` helper #25374

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202206-test-remove_unused_create_confirmed_utxos_helper changing 1 files +0 −33

theStack commented at 11:15 PM on June 14, 2022: member

After more and more non-wallet tests have been converted to use MiniWallet (#25087, #24839, #24749 etc.), the create_confirmed_utxos helper is now not used anymore and can be removed. An alternative would be to create a MiniWallet version of create_confirmed_utxos, but it seems that it's not worth it, considering that would be only two lines (calling MiniWallet's send_self_transfer_multi with a subsequent generate call), see comment #24839 (review).

test: remove unused `create_confirmed_utxos` helper

Confirmed UTXOs in functional tests can simply be created by using
MiniWallet's `send_self_transfer_multi` method with a subsequent
`generate` call to mine a block.

42b2fdfd5f

DrahtBot added the label Tests on Jun 14, 2022
MarcoFalke commented at 6:20 AM on June 15, 2022: member

cr ACK 42b2fdfd5f9d854fe05a248278fc309a6a9fa6bc
MarcoFalke merged this on Jun 15, 2022
MarcoFalke closed this on Jun 15, 2022
theStack deleted the branch on Jun 15, 2022
sidhujag referenced this in commit 1630aae6a4 on Jun 15, 2022
DrahtBot locked this on Jun 15, 2023

Contributors

theStack

MarcoFalke

Labels

Tests

Linked (view graph)

#24749 test: use MiniWallet for mempool_unbroadcast.py #24839 test: use MiniWallet for mining_prioritisetransaction.py #25087 test: use MiniWallet for feature_dbcrash.py