Bugfix: Store last/next wallet resend times unique per CWallet object #2541

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bugfix_wallet_resend changing 2 files +8 −7

luke-jr commented at 9:31 PM on April 19, 2013: member

As soon as we have multiple CWallet objects, this bug would cause them to interfere with each other rebroadcasting.
sipa commented at 8:38 PM on April 23, 2013: member

Any reason not to just call the variables nNextTime/nLastTime, or rename their usages to nNextRetry/nLastRetry? That reference looks like a hack to avoid code changes :)
sipa commented at 8:38 PM on April 23, 2013: member

ACK otherwise, by the way.
BitcoinPullTester commented at 9:53 PM on April 26, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1ee947d0573f8f0b5ae8c5efb27fae376e867187 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 1:54 PM on May 5, 2013: member

ACK (after squashing into one commit)

Edit: and I agree with @sipa on the use of references, please just rename the variables.
jgarzik commented at 4:46 PM on May 30, 2013: contributor

ACK, once @laanwj and @sipa comments applied
Bugfix: Store last/next wallet resend times unique per CWallet object 203d1ae69b
luke-jr commented at 3:01 AM on July 17, 2013: member

Rebased with requested refactor.
BitcoinPullTester commented at 10:13 AM on July 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/203d1ae69b1b606c0216d0dc35de567c591720ae for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa referenced this in commit 4bb77b4963 on Jul 29, 2013
sipa merged this on Jul 29, 2013
sipa closed this on Jul 29, 2013
luke-jr deleted the branch on Oct 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors