rpc: Return incrementalrelayfee in getmempoolinfo #25439

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2206-rpc-policy-🥙 changing 2 files +5 −2

MarcoFalke commented at 4:08 PM on June 21, 2022: member

Seems odd to return other policy info, but not the incremental relay fee
rpc: Return incrementalrelayfee in getmempoolinfo fafee78188
fanquake added the label RPC/REST/ZMQ on Jun 21, 2022
unknown approved
unknown commented at 4:39 PM on June 21, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/25439/commits/fafee78188c3de5f6245ec769429822ca4b98c63
w0xlt approved
w0xlt commented at 4:59 PM on June 21, 2022: contributor

Code Review ACK https://github.com/bitcoin/bitcoin/pull/25439/commits/fafee78188c3de5f6245ec769429822ca4b98c63
DrahtBot commented at 5:22 PM on June 21, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25353 (Add a -mempoolfullrbf node setting by ariard)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
brunoerg commented at 11:50 PM on June 21, 2022: member

Concept ACK

jarolrod commented at 3:45 AM on June 27, 2022: member

tACK fafee78188c3de5f6245ec769429822ca4b98c63

{
  "loaded": true,
  "size": 1,
  "bytes": 141,
  "usage": 1168,
  "total_fee": 0.00000141,
  "maxmempool": 300000000,
  "mempoolminfee": 0.00001000,
  "minrelaytxfee": 0.00001000,
  "incrementalrelayfee": 0.00001000,
  "unbroadcastcount": 0
}

MarcoFalke merged this on Jun 27, 2022
MarcoFalke closed this on Jun 27, 2022
MarcoFalke deleted the branch on Jun 27, 2022

in src/rpc/mempool.cpp:685 in fafee78188

 681 | @@ -681,7 +682,8 @@ static RPCHelpMan getmempoolinfo()
 682 |                  {RPCResult::Type::NUM, "maxmempool", "Maximum memory usage for the mempool"},
 683 |                  {RPCResult::Type::STR_AMOUNT, "mempoolminfee", "Minimum fee rate in " + CURRENCY_UNIT + "/kvB for tx to be accepted. Is the maximum of minrelaytxfee and minimum mempool fee"},
 684 |                  {RPCResult::Type::STR_AMOUNT, "minrelaytxfee", "Current minimum relay fee for transactions"},
 685 | -                {RPCResult::Type::NUM, "unbroadcastcount", "Current number of transactions that haven't passed initial broadcast yet"}
 686 | +                {RPCResult::Type::NUM, "incrementalrelayfee", "minimum fee rate increment for mempool limiting or BIP 125 replacement in " + CURRENCY_UNIT + "/kvB"},