Currently, connect_nodes will return silently when the connection is disconnected while connecting. This is confusing, so fix it.
Can be tested by reverting the signet test change and observing the failure when running the test.
test: Fail if connect_nodes fails #25443
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2206-test-fail-connect-👇 changing 2 files +15 −5-
MarcoFalke commented at 7:09 AM on June 22, 2022: member
-
faee330c7b
test: Fail if connect_nodes fails
Also replace the use of wait_until_helper, which is not allowed to be called directly. Otherwise, --timeout-factor will not be honoured.
- MarcoFalke force-pushed on Jun 22, 2022
- DrahtBot added the label Tests on Jun 22, 2022
-
laanwj commented at 10:19 AM on June 22, 2022: member
Tested ACK faee330c7bde4d52dc18cf55166b5975b26bdecd Silent failures are really bad in general, even more so in tests which are supposed to raise a stink on problems. Tested that removing the
setup_networkfunction makes the test fail. - laanwj merged this on Jun 22, 2022
- laanwj closed this on Jun 22, 2022
- MarcoFalke deleted the branch on Jun 22, 2022
- sidhujag referenced this in commit 51fcdf5749 on Jun 22, 2022
- sidhujag referenced this in commit be55b495c5 on Jun 22, 2022
- DrahtBot locked this on Jun 22, 2023
Contributors
Labels