test: Fail if connect_nodes fails #25443

1. 
   MarcoFalke commented at 7:09 am on June 22, 2022: member

   Currently, connect_nodes will return silently when the connection is disconnected while connecting. This is confusing, so fix it.

   Can be tested by reverting the signet test change and observing the failure when running the test.

2. test: Fail if connect_nodes fails

   Also replace the use of wait_until_helper, which is not allowed to be
   called directly. Otherwise, --timeout-factor will not be honoured.

   faee330c7b
3. MarcoFalke force-pushed on Jun 22, 2022
4. DrahtBot added the label Tests on Jun 22, 2022
5. 
   laanwj commented at 10:19 am on June 22, 2022: member

   Tested ACK faee330c7bde4d52dc18cf55166b5975b26bdecd Silent failures are really bad in general, even more so in tests which are supposed to raise a stink on problems. Tested that removing the setup_network function makes the test fail.
6. laanwj merged this on Jun 22, 2022
7. laanwj closed this on Jun 22, 2022

   ---

8. MarcoFalke deleted the branch on Jun 22, 2022
9. sidhujag referenced this in commit 51fcdf5749 on Jun 22, 2022
10. sidhujag referenced this in commit be55b495c5 on Jun 22, 2022
11. DrahtBot locked this on Jun 22, 2023

Contributors
MarcoFalke laanwj

Labels
Tests