test: fix failing test `interface_usdt_utxocache.py` #25486

1. 
   theStack commented at 5:47 PM on June 27, 2022: member

   The from_node argument doesn't exist anymore for MiniWallet.create_self_transfer since PR #25435 (commit fa8421bc5bcd483a9501257073db17ff2e76eb46), leading to an error on master:

   $ sudo ./test/functional/interface_usdt_utxocache.py
   2022-06-27T17:45:35.585000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_7s1djjo1
   2022-06-27T17:45:36.515000Z TestFramework (INFO): testing the utxocache:uncache tracepoint API
   2022-06-27T17:45:36.517000Z TestFramework (ERROR): Unexpected exception caught during testing
   Traceback (most recent call last):
     File "/home/honeybadger/bitcoin/test/functional/test_framework/test_framework.py", line 133, in main
       self.run_test()
     File "/home/honeybadger/bitcoin/./test/functional/interface_usdt_utxocache.py", line 149, in run_test
       self.test_uncache()
     File "/home/honeybadger/bitcoin/./test/functional/interface_usdt_utxocache.py", line 172, in test_uncache
       invalid_tx = self.wallet.create_self_transfer(
   TypeError: create_self_transfer() got an unexpected keyword argument 'from_node'
   2022-06-27T17:45:36.568000Z TestFramework (INFO): Stopping nodes
   [...]
   

   Fix this by removing the argument. (Unfortunately, the USDT tests don't seem to run on any CI target, I guess that's due to missing permissions to hook into the kernel.)

2. test: fix failing test interface_usdt_utxocache.py

   The `from_node` argument doesn't exist anymore for
   `MiniWallet.create_self_transfer` since PR #25435 (commit
   fa8421bc5bcd483a9501257073db17ff2e76eb46).

   f665c6ecda
3. DrahtBot added the label Tests on Jun 27, 2022
4. MarcoFalke requested review from 0xB10C on Jun 28, 2022
5. 
   MarcoFalke commented at 6:30 AM on June 28, 2022: member

   Yeah, doesn't look like this is run in CI.

   cr ACK f665c6ecda854adaaa629e961b1912847b42fd34

6. MarcoFalke merged this on Jun 28, 2022
7. MarcoFalke closed this on Jun 28, 2022

   ---

8. 
   ayush933 commented at 6:34 AM on June 28, 2022: contributor

   crACK f665c6ec

9. 
   0xB10C commented at 6:59 AM on June 28, 2022: member

   Thanks for fixing!

   I'll give #24782 another shot.

10. theStack deleted the branch on Jun 28, 2022
11. sidhujag referenced this in commit 0a8855a30e on Jun 28, 2022
12. 
    0xB10C commented at 9:21 PM on June 30, 2022: member

    @theStack did you test that this fixed the failing test? It's still failing for me though with a different error.

    Bisecting yields fa13375aa3fcb4fd5b9e0d4c69ac31cf66c3209a ~which makes sense as it adds a call to rescan_utxos() which calls the scantxoutset RPC which internally flushes the utxo set cache. The expected numbers of flushes doesn't match anymore.~ It seems to be more subtle than that.

    I'm working on CI tests for the interface tests and will include a fix there.

13. 
    theStack commented at 10:12 AM on July 1, 2022: member

    @theStack did you test that this fixed the failing test? It's still failing for me though with a different error.

    Oops, seems I didn't, apparently I ran one of the other USDT tests after the change 🤔

    I'm working on CI tests for the interface tests and will include a fix there.

    Feel free to tag me in this PR, happy to test (won't have access to a local machine where I can run USDT stuff for the next few days, but will follow up when I have again).

14. 0xB10C referenced this in commit 9dd7df2d46 on Jul 2, 2022
15. 0xB10C referenced this in commit dba6f82342 on Jul 2, 2022
16. 0xB10C referenced this in commit 0e20a52396 on Jul 29, 2022
17. stickies-v referenced this in commit 4f689e2050 on Aug 2, 2022
18. Rspigler referenced this in commit e73bd97ddd on Aug 21, 2022
19. janus referenced this in commit 66d8ac6ca9 on Jan 20, 2023
20. DrahtBot locked this on Jul 1, 2023

Review Requested
0xB10C