wallet: more accurate target for large transactions #25497

pull S3RK wants to merge 1 commits into bitcoin:master from S3RK:wallet_noninput_fees changing 1 files +2 −1

S3RK commented at 7:25 AM on June 29, 2022: member

Rationale: more accurate non-input fee estimation for txs with >=253 inputs
wallet: more accurate tx_noinputs_size 25e4762ae7
DrahtBot added the label Wallet on Jun 29, 2022
laanwj commented at 11:14 AM on June 29, 2022: member

Concept and code review ACK 25e4762ae7a09906020e62cd947e9f71300439cf
DrahtBot commented at 11:57 AM on June 29, 2022: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.

in src/wallet/spend.cpp:763 in 25e4762ae7

 759 | @@ -760,7 +760,8 @@ static std::optional<CreatedTransactionResult> CreateTransactionInternal(
 760 |  
 761 |      // vouts to the payees
 762 |      if (!coin_selection_params.m_subtract_fee_outputs) {
 763 | -        coin_selection_params.tx_noinputs_size = 11; // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1 input count, 1 output count, 1 witness overhead (dummy, flag, stack size)
 764 | +        coin_selection_params.tx_noinputs_size = 10; // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1 input count, 1 witness overhead (dummy, flag, stack size)

furszy commented at 1:06 PM on June 29, 2022:

nit: outputs size is added in the next line now.

        coin_selection_params.tx_noinputs_size = 10; // Static vsize overhead. 4 nVersion, 4 nLocktime, 1 input count, 1 witness overhead (dummy, flag, stack size)

furszy commented at 1:08 PM on June 29, 2022: member

Code review ACK 25e4762a. left a small nit.
achow101 commented at 3:41 PM on June 29, 2022: member

ACK 25e4762ae7a09906020e62cd947e9f71300439cf
achow101 merged this on Jun 29, 2022
achow101 closed this on Jun 29, 2022
DrahtBot locked this on Jun 29, 2023

Contributors

Labels

wallet: more accurate target for large transactions #25497

Conflicts