wallet: don't add change fee to target if subtracting fees from output #25507

pull S3RK wants to merge 1 commits into bitcoin:master from S3RK:correct_target_with_sffo changing 1 files +7 −4

S3RK commented at 7:03 AM on June 30, 2022: member

Change fee is payed by the recipient, so we don't need to add it to our target for coin selection.
wallet: don't add change fee to target if subtracting fees from output 140d942634
DrahtBot added the label Wallet on Jun 30, 2022
achow101 commented at 3:35 PM on June 30, 2022: member

ACK 140d942634f9f1bba191aafa948df57812c0f3fe
DrahtBot commented at 8:00 PM on June 30, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24584 (wallet: avoid mixing different OutputTypes during coin selection by josibake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ishaanam commented at 11:16 AM on July 1, 2022: member

ACK 140d942634f9f1bba191aafa948df57812c0f3fe
furszy approved
furszy commented at 12:34 PM on July 1, 2022: member

Code review ACK 140d9426
christ79ma approved
achow101 merged this on Jul 6, 2022
achow101 closed this on Jul 6, 2022
DrahtBot locked this on Jul 6, 2023

Contributors

Labels