test: remove wallet dependency and refactor rpc_signrawtransaction.py #25512

pull ayush933 wants to merge 1 commits into bitcoin:master from ayush933:rpc_signrawtransactionwithkey_no_wallet changing 3 files +146 −99

ayush933 commented at 2:05 PM on June 30, 2022: contributor
rpc_signrawtransaction.py currently tests the signrawtransactionwithkey and signrawtransactionwithwallet RPCs.

This PR splits rpc_signrawtransaction.py into
1. rpc_signrawtransactionwithkey.py: the tests for signrawtransactionwithkey are moved here and this test can now be run with the wallet disabled.
2. wallet_signrawtransactionwithwallet.py: wallet only tests for signrawtransactionwithwallet.py

test: refactor rpc_signrawtransaction.py

rpc_signrawtransaction.py is split into rpc_signrawtransactionwithkey.py and wallet_signrawtransactionwithwallet.py.
rpc_signrawtransactionwithkey.py can be run with the wallet disabled.

0ee43d13e9

fanquake added the label Tests on Jun 30, 2022
DrahtBot commented at 7:55 PM on June 30, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ayush933 renamed this:
~~test: refactor rpc_signrawtransaction.py~~
test:remove wallet dependency and refactor rpc_signrawtransaction.py
on Jul 1, 2022
ayush933 renamed this:
~~test:remove wallet dependency and refactor rpc_signrawtransaction.py~~
test: remove wallet dependency and refactor rpc_signrawtransaction.py
on Jul 1, 2022
aureleoules commented at 12:05 PM on July 6, 2022: member

tACK 0ee43d13e993a59fe1ba509f617dd0e01e1068e2. I verified that the tests were not altered during the refactor.

My understanding is that self.nodes[0].sendtoaddress was replaced with the function send_to_address to remove the wallet dependency.
MarcoFalke merged this on Jul 11, 2022
MarcoFalke closed this on Jul 11, 2022

in test/functional/rpc_signrawtransactionwithkey.py:48 in 0ee43d13e9

  43 | +        input = {"txid": self.nodes[0].getblock(self.block_hash[self.blk_idx])["tx"][0], "vout": 0}
  44 | +        output = {addr: amount}
  45 | +        self.blk_idx += 1
  46 | +        rawtx = self.nodes[0].createrawtransaction([input], output)
  47 | +        txid = self.nodes[0].sendrawtransaction(self.nodes[0].signrawtransactionwithkey(rawtx, [self.nodes[0].get_deterministic_priv_key().key])["hex"], 0)
  48 | +        return txid

MarcoFalke commented at 1:42 PM on July 11, 2022:

nit: As an idea for the future, this method could be removed and replaced by MiniWallet.send_to to simplify the test logic a bit. Or alternatively, the def make_utxo(self, node, amount, *, confirmed=True, scriptPubKey=None): method from feature_rbf could be moved to the test_framework and reused here?

sidhujag referenced this in commit a2af5feeb9 on Jul 11, 2022
bitcoin locked this on Jul 11, 2023

Contributors

Labels

test: remove wallet dependency and refactor rpc_signrawtransaction.py #25512

Conflicts