build: Remove outdated libbitcoinkernel comment #25521

pull bubelov wants to merge 1 commits into bitcoin:master from bubelov:libbitcoinkernel-note changing 1 files +1 −2
  1. bubelov commented at 7:44 AM on July 1, 2022: contributor

    Looks like this comment is no longer relevant, the last files which matched index/*.cpp pattern were removed in https://github.com/bitcoin/bitcoin/commit/f1006875665ffe8ff5da8185effe25b860743b4e

  2. Remove outdated comment 18f5355f3a
  3. MarcoFalke renamed this:
    build: Remove outdated comment
    build: Remove outdated libbitcoinkernel comment
    on Jul 1, 2022
  4. MarcoFalke added the label Refactoring on Jul 1, 2022
  5. MarcoFalke requested review from dongcarl on Jul 1, 2022
  6. shaavan approved
  7. shaavan commented at 8:58 AM on July 1, 2022: contributor

    ACK 18f5355f3ad8a5513c99c5b0ca14266b604362cc

    I was able to verify that the files corresponding to index/*.cpp have been removed from the libbitcoinkernel_la_SOURCES. So the comment "... things like index/*.cpp will be removed." is now redundant.

  8. dongcarl commented at 7:18 PM on July 1, 2022: member

    ACK 18f5355f3ad8a5513c99c5b0ca14266b604362cc

  9. MarcoFalke merged this on Jul 1, 2022
  10. MarcoFalke closed this on Jul 1, 2022

  11. DrahtBot locked this on Jul 1, 2023


dongcarl


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me