Looks like this comment is no longer relevant, the last files which matched index/*.cpp pattern were removed in https://github.com/bitcoin/bitcoin/commit/f1006875665ffe8ff5da8185effe25b860743b4e
build: Remove outdated libbitcoinkernel comment #25521
pull bubelov wants to merge 1 commits into bitcoin:master from bubelov:libbitcoinkernel-note changing 1 files +1 −2-
bubelov commented at 7:44 AM on July 1, 2022: contributor
-
Remove outdated comment 18f5355f3a
- MarcoFalke renamed this:
build: Remove outdated comment
build: Remove outdated libbitcoinkernel comment
on Jul 1, 2022 - MarcoFalke added the label Refactoring on Jul 1, 2022
- MarcoFalke requested review from dongcarl on Jul 1, 2022
- shaavan approved
-
shaavan commented at 8:58 AM on July 1, 2022: contributor
ACK 18f5355f3ad8a5513c99c5b0ca14266b604362cc
I was able to verify that the files corresponding to
index/*.cpphave been removed from thelibbitcoinkernel_la_SOURCES. So the comment "... things like index/*.cpp will be removed." is now redundant. -
dongcarl commented at 7:18 PM on July 1, 2022: member
ACK 18f5355f3ad8a5513c99c5b0ca14266b604362cc
- MarcoFalke merged this on Jul 1, 2022
- MarcoFalke closed this on Jul 1, 2022
- DrahtBot locked this on Jul 1, 2023