contrib: dedup get_witness_script helper in signet miner #25536

1. 
   theStack commented at 6:15 pm on July 3, 2022: member

   The helper get_witness_script is already available in the blocktools module of our test framework, i.e. there is no need to re-implement it in the signet miner script. Note that the cast from CScript to bytes is necessary for applying the += operator on the scriptPubKey later, which would fail for CScript:

   0  File "/home/honeybadger/bitcoin/contrib/signet/miner", line 132, in signet_txs
   1    txs[0].vout[-1].scriptPubKey += CScriptOp.encode_op_pushdata(SIGNET_HEADER)
   2  File "/home/honeybadger/bitcoin/test/functional/test_framework/script.py", line 460, in __add__
   3    raise NotImplementedError
   4NotImplementedError
   

2. theStack force-pushed on Jul 3, 2022
3. contrib: dedup `get_witness_script` helper in signet miner cccf691c24
4. theStack force-pushed on Jul 3, 2022
5. fanquake deleted a comment on Jul 3, 2022
6. fanquake requested review from ajtowns on Jul 3, 2022
7. fanquake requested review from kallewoof on Jul 3, 2022
8. fanquake added the label Scripts and tools on Jul 3, 2022
9. 
   ajtowns commented at 11:51 am on July 4, 2022: member

   Concept ACK
10. MarcoFalke removed the label Scripts and tools on Jul 4, 2022
11. DrahtBot added the label Scripts and tools on Jul 4, 2022
12. 
    kallewoof commented at 10:36 am on July 5, 2022: member

    ACK cccf691c24f9cbc4aedd1b36c1d9ba173910ceca
13. fanquake merged this on Jul 5, 2022
14. fanquake closed this on Jul 5, 2022

    ---

15. theStack deleted the branch on Jul 5, 2022
16. sidhujag referenced this in commit 0c28201e03 on Jul 5, 2022
17. DrahtBot locked this on Jul 5, 2023

Contributors
theStack ajtowns kallewoof

Review Requested
ajtowns

Labels
Scripts and tools