Remove Taproot specific references in functional tests to "inner key" and replace with "internal key" as used in BIP 341
test: Rename inner key to internal key #25553
pull michaelfolkson wants to merge 1 commits into bitcoin:master from michaelfolkson:2022-07-test-internal-key changing 2 files +3 −3-
michaelfolkson commented at 10:34 AM on July 6, 2022: contributor
-
test: Rename inner key to internal key 03c724f3d4
- fanquake added the label Tests on Jul 6, 2022
-
aureleoules commented at 12:19 PM on July 6, 2022: member
LGTM
-
DrahtBot commented at 11:05 AM on September 23, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
achow101 commented at 3:17 PM on October 13, 2022: member
-0 on this.
While "inner key" is technically incorrect, it is close enough to the real name that it is not confusing or misleading. I think we generally avoid renaming things as that makes bisecting/blaming more difficult. It's why we don't also just go through and fix every typo in the repo.
-
michaelfolkson commented at 10:39 AM on November 8, 2022: contributor
@achow101: Gotcha, thanks for the response. Will close.
- michaelfolkson closed this on Nov 8, 2022
- michaelfolkson deleted the branch on Nov 8, 2022
- bitcoin locked this on Nov 8, 2023
Contributors
Labels