Remove my key from trusted-keys #25568

pull sipa wants to merge 1 commits into bitcoin:master from sipa:202207_dropme changing 1 files +0 −1
  1. sipa commented at 8:55 pm on July 7, 2022: member
  2. Remove my key from trusted-keys 8cbeab4d90
  3. hebasto commented at 9:00 pm on July 7, 2022: member
    Should the contrib/verify-commits/trusted-git-root be updated as well?
  4. instagibbs commented at 9:08 pm on July 7, 2022: member
    verified that the key 133EAC179436F14A5CF1B794860FEB804E669320 is indeed the one I have in my keyring
  5. achow101 commented at 9:16 pm on July 7, 2022: member

    Should the contrib/verify-commits/trusted-git-root be updated as well?

    I don’t think so. @sipa’s last merge predates the current trusted-git-root by more than a year.

  6. laanwj added the label Scripts and tools on Jul 7, 2022
  7. laanwj commented at 9:25 pm on July 7, 2022: member

    Should the contrib/verify-commits/trusted-git-root be updated as well?

    Let’s see if the checks still pass.

  8. kristapsk approved
  9. kristapsk commented at 9:40 pm on July 7, 2022: contributor
    ACK 8cbeab4d90437765d1e63b95ede81e4d5e7c975f
  10. achow101 commented at 10:36 pm on July 7, 2022: member

    ACK 8cbeab4d90437765d1e63b95ede81e4d5e7c975f

    The key removed is the same as the one in my keyring.

    Let’s see if the checks still pass.

    We don’t do verify-commits for PRs, so CI won’t help here.

    I’ve run verify-commits locally with the key removed and the current trusted-git-root and there were no issues.

  11. unknown approved
  12. unknown commented at 0:18 am on July 8, 2022: none

    ACK https://github.com/bitcoin/bitcoin/pull/25568/commits/8cbeab4d90437765d1e63b95ede81e4d5e7c975f

    Verified the fingerprint from https://bitcoincore.org/en/contact/

    Thank you for being a bitcoin core maintainer since May 2011. I have learn a lot of things reading your posts and will keep learning as you will still be active as a contributor.

    An OP_RETURN tx for memories: https://mempool.space/tx/830e6cb9ae8a35efa23c1053db942db8abe7d3f362f6173638860ee7849507ae

  13. b3h3rkz commented at 0:55 am on July 8, 2022: none

    Thank you @sipa!

    Beautiful OP_RETURN @1440000bytes 💯

  14. junderw commented at 1:26 am on July 8, 2022: contributor

    ACK 8cbeab4d90437765d1e63b95ede81e4d5e7c975f

    Thanks for everything @sipa and good luck on your future endeavors.

  15. Zero-1729 approved
  16. Zero-1729 commented at 5:18 am on July 8, 2022: contributor

    ACK 8cbeab4d90437765d1e63b95ede81e4d5e7c975f

    Verified fingerprint matches the key in my keyring.

    Thank you @sipa for all your work on core, and invaluable responses on bitcoin.stackexchange.

    Best of wishes on your next chapter!

  17. MarcoFalke merged this on Jul 8, 2022
  18. MarcoFalke closed this on Jul 8, 2022

  19. MarcoFalke locked this on Feb 7, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me