Some database/-related recovery improvements #2558

1. 
   sipa commented at 10:48 pm on April 23, 2013: member

   • After clean shutdown, delete the database/ subdir. This means upgrading/changing the BDB dir won’t kill you anymore because of incompatible logs.
   • In case opening the database environment fails, move database/ to database.$TIMESTAMP.bak, and try again.
   • Do not advise the user to nuke his datadir anymore - there’s no point in doing so (closes #2488).
   • Drop double opening of the environment (includes #2333).
2. remove duplicate bitdb.Open() code from init

   - remove code from step 7, which we already have in step 5 of init

   e79110822e
3. Try moving database/ away in case of failure 1859aafef0
4. Remove database/ after clean shutdown ccda03b570
5. 
   BitcoinPullTester commented at 8:29 pm on April 26, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ccda03b57022369c4352d0f5a816cff9ace833e6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
6. 
   laanwj commented at 9:12 am on April 27, 2013: member

   ACK
7. 
   Diapolo commented at 9:17 pm on April 28, 2013: none

   Looks good and should make it for 0.8.2 IMHO.
8. 
   jgarzik commented at 9:11 pm on May 3, 2013: contributor

   ACK code

   I’d say it needs testing on Windows, to make sure the looks-right-on-Unix code works there. Or maybe I’m just being paranoid.

9. 
   gavinandresen commented at 9:18 pm on May 3, 2013: contributor

   ACK. Compiles and works as advertised on OSX.
10. sipa referenced this in commit 674ae7a26f on May 3, 2013
11. sipa merged this on May 3, 2013
12. sipa closed this on May 3, 2013

    ---

13. sipa deleted the branch on May 3, 2013
14. laudney referenced this in commit 01f0042b11 on Mar 19, 2014
15. DrahtBot locked this on Feb 15, 2022

Contributors
sipa BitcoinPullTester laanwj Diapolo jgarzik gavinandresen

Milestone
v0.8.2