scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE #25596

1. 
   MarcoFalke commented at 3:19 pm on July 12, 2022: member

   Not sure why the python constant is named differently than the constant in the C++ source code.

   Especially, if we use this in context of MAX+1 (https://github.com/bitcoin/bitcoin/pull/25575#discussion_r918569813) the rename makes sense, in my eyes.

2. fanquake requested review from glozow on Jul 12, 2022
3. 
   theStack commented at 4:46 pm on July 12, 2022: contributor

   Concept ACK

   Note that the test rpc_psbt.py actually also defines MAX_BIP125_RBF_SEQUENCE, i.e. I’d propose the following additional patch after the scripted-diff:

    0diff --git a/test/functional/rpc_psbt.py b/test/functional/rpc_psbt.py
    1index d2a888fd3..264b2ac32 100755
    2--- a/test/functional/rpc_psbt.py
    3+++ b/test/functional/rpc_psbt.py
    4@@ -11,8 +11,9 @@ from itertools import product
    5 from test_framework.descriptors import descsum_create
    6 from test_framework.key import ECKey, H_POINT
    7 from test_framework.messages import (
    8-    ser_compact_size,
    9+    MAX_BIP125_RBF_SEQUENCE,
   10     WITNESS_SCALE_FACTOR,
   11+    ser_compact_size,
   12 )
   13 from test_framework.test_framework import BitcoinTestFramework
   14 from test_framework.util import (
   15@@ -27,7 +28,6 @@ from test_framework.wallet_util import bytes_to_wif
   16 import json
   17 import os
   18
   19-MAX_BIP125_RBF_SEQUENCE = 0xfffffffd
   20
   21 # Create one-input, one-output, no-fee transaction:
   22 class PSBTTest(BitcoinTestFramework):
   

4. scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE

   -BEGIN VERIFY SCRIPT-
    sed -i 's:BIP125_SEQUENCE_NUMBER:MAX_BIP125_RBF_SEQUENCE:g' $(git grep -l BIP125_SEQUENCE_NUMBER ./test)
   -END VERIFY SCRIPT-

   fa0404dbb7
5. test: Remove duplicate MAX_BIP125_RBF_SEQUENCE constant faace13b71
6. MarcoFalke force-pushed on Jul 12, 2022
7. DrahtBot added the label Refactoring on Jul 12, 2022
8. theStack approved
9. 
   theStack commented at 10:48 pm on July 12, 2022: contributor

   Code-review ACK faace13b712a349863eaf7c469069db17b6e9dd5
10. 
    DrahtBot commented at 6:09 am on July 13, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. MarcoFalke assigned glozow on Jul 13, 2022
12. 
    glozow commented at 7:22 am on July 13, 2022: member

    concept ACK faace13b712a349863eaf7c469069db17b6e9dd5
13. fanquake requested review from instagibbs on Jul 13, 2022
14. MarcoFalke merged this on Jul 13, 2022
15. MarcoFalke closed this on Jul 13, 2022

    ---

16. MarcoFalke deleted the branch on Jul 13, 2022
17. sidhujag referenced this in commit 53f09bb50c on Jul 13, 2022
18. bitcoin locked this on Jul 13, 2023

Contributors
MarcoFalke theStack DrahtBot glozow

Review Requested
instagibbs

Labels
Refactoring