decodepsbt RPC in the case that a PSBT with on of the per-input preimage types (PSBT_IN_RIPEMD160, PSBT_IN_SHA256, PSBT_IN_HASH160, PSBT_IN_HASH256; see BIP 174) is passed. As preparation, the first four commits move the already existing helpers for (de)serialization of PSBTs and PSBTMaps from the signet miner to the test framework (in a new module psbt.py), which should be quite useful for further tests to easily create PSBTs.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-BEGIN VERIFY SCRIPT-
sed -i s/FromBinary/from_binary/g ./contrib/signet/miner
-END VERIFY SCRIPT-
Can be easily reviewed with `--color-moved=dimmed-zebra`.
Can be easily reviewed with `--color-moved=dimmed-zebra`.
Also take use of the constants in the signet miner to get rid of
magic numbers and increase readability and maintainability.
787@@ -775,5 +788,37 @@ def test_psbt_input_keys(psbt_input, keys):
788 self.nodes[0].sendrawtransaction(rawtx)
789 self.generate(self.nodes[0], 1)
790
791+ self.log.info("Test decoding PSBT with per-input preimage types")
792+ # note that the decodepsbt RPC doesn't check whether preimages and hashes match
793+ hash_ripemd160, preimage_ripemd160 = os.urandom(20), os.urandom(50)
this is the first instance of urandom in the test framework. Can we make it seed-determined instead, so that failures can be diagnosed easier?
If we don’t expect failures due to randomness, we probably shouldn’t do it at all then.
random_bytes helper (which uses random.getrandbits) from the taproot test to the utils library and used that instead. Note that Python 3.9 offers random.randbytes(), but unfortunately we have Python 3.6 as minimum requirement.
Can be easily reviewed with `--color-moved=dimmed-zebra`.
random module and hence could be reproduced by passing a PRNG seed (which is printed out in the test framework log).