Tracing: coins.cpp:102:22: error: 'coin' used after it was moved [bugprone-use-after-move] #25640

issue MarcoFalke opened this issue on July 19, 2022

MarcoFalke commented at 9:18 AM on July 19, 2022: member

This may be fine because int values aren't touched by a std::move, but it seems brittle and confusing:

coins.cpp:102:22: error: 'coin' used after it was moved [bugprone-use-after-move,-warnings-as-errors]
           (uint32_t)coin.nHeight,
                     ^
coins.cpp:96:21: note: move occurred here
    it->second.coin = std::move(coin);
                    ^

MarcoFalke added the label Refactoring on Jul 19, 2022
MarcoFalke referenced this in commit f5eadcb148 on Aug 1, 2022
MarcoFalke closed this on Aug 1, 2022
sidhujag referenced this in commit ce9edec74b on Aug 1, 2022
MarcoFalke referenced this in commit 52dcb1d2a3 on Aug 30, 2022
sidhujag referenced this in commit 1ed11c09ae on Aug 31, 2022
PastaPastaPasta referenced this in commit 48b85e3744 on Oct 18, 2022
bitcoin locked this on Aug 1, 2023

Contributors

MarcoFalke

Labels

Refactoring

Linked (view graph)

#25663 tracing: do not use `coin` after move in `CCoinsViewCache::AddCoin`#25733 tidy: enable bugprone-use-after-move