fuzz: Remove no-op SetMempoolConstraints #25689

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2207-fuzz-tx-pool-noop-📕 changing 1 files +2 −8
  1. MarcoFalke commented at 2:28 PM on July 24, 2022: member

    Now that the mempool no longer uses the args manager (after commit e4e201dfd9a9dbd8e22cac688dbbde16234cd937), there is no point setting the mempool limits after it is constructed.

    Fix that by setting them once right before the mempool is constructed.

  2. fuzz: Remove no-op SetMempoolConstraints fa57c449cf
  3. DrahtBot commented at 4:36 PM on July 24, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25648 (refactor: Remove all policy globals by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. fanquake requested review from glozow on Jul 25, 2022
  5. glozow commented at 2:01 PM on July 25, 2022: member

    utACK fa57c449cf45a4f1df195970c711bba8f02f3cc6

  6. glozow requested review from dongcarl on Jul 25, 2022
  7. dongcarl commented at 3:34 PM on July 25, 2022: contributor

    utACK fa57c449cf45a4f1df195970c711bba8f02f3cc6

    I kinda wish these acted on CTxMemPool::Options rather than ArgsManager, but thanks to the MakeMempool helper I guess it doesn't really matter either way.

  8. glozow merged this on Jul 26, 2022
  9. glozow closed this on Jul 26, 2022

  10. MarcoFalke deleted the branch on Jul 26, 2022
  11. sidhujag referenced this in commit f60c1657b5 on Jul 27, 2022
  12. bitcoin locked this on Aug 18, 2023


dongcarl


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me