Allow select()ing up to 1024 file descriptors on Windows #2569

1. 
   sipa commented at 11:08 PM on April 25, 2013: member

   Closes #2408.

2. Allow select()ing up to 1024 file descriptors on Windows 33912d1f23
3. 
   gavinandresen commented at 4:06 PM on April 26, 2013: contributor

   Is there a good way to test this? It is simple enough that I'd be satisified with a link to (say) a MSDN page that says this is what you do to select() up to 1024 file descriptors on windows....

4. 
   jgarzik commented at 4:27 PM on April 26, 2013: contributor

   agreed, @gavinandresen

5. 
   Diapolo commented at 5:44 PM on April 26, 2013: none

   See http://support.microsoft.com/kb/111855 - Maximum Number of Sockets an Application Can Use

6. 
   BitcoinPullTester commented at 6:08 PM on April 26, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/33912d1f237537f51f29ca06e3e396f04aeb4671 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

7. 
   laanwj commented at 3:04 PM on April 28, 2013: member

   ACK

8. 
   Diapolo commented at 8:24 PM on April 28, 2013: none

   For Windows An application should make no assumptions about the availability of a certain number of sockets., so I hope we don't rely on the number set here in any way?

9. 
   gavinandresen commented at 1:30 PM on April 29, 2013: contributor

   ACK as "better than the code we have now."

10. 
    sipa commented at 1:42 PM on April 29, 2013: member

    @Diapolo This is really just about how many sockets we watch simultaneously. If not enough sockets are available for what the user requests, opening them will just fail.

11. 
    Diapolo commented at 4:25 PM on April 29, 2013: none

    ACK

12. laanwj referenced this in commit 7226806e8d on Apr 29, 2013
13. laanwj merged this on Apr 29, 2013
14. laanwj closed this on Apr 29, 2013

    ---

15. sipa deleted the branch on May 3, 2013
16. laudney referenced this in commit 46af733197 on Mar 19, 2014
17. DrahtBot locked this on Sep 8, 2021

Milestone
v0.8.2