univalue: hand written conversion of number to string #25711

1. 
   MarcoFalke commented at 12:55 pm on July 26, 2022: member

   This commit is taken from https://github.com/bitcoin-core/univalue-subtree/commit/284f76366b085f6de9ffaa1d7767de71eab2868e (first commit of https://github.com/bitcoin-core/univalue-subtree/pull/27).
2. hand written conversion of number to string

   The function appendNumToString is much faster than using a temporary
   ostringstream. The implementation is locale independent, and does not
   allocate any additional memory.
   
   In my tests, Bitcoin's BlockToJsonVerbose benchmark runs ~11% faster
   with that patch.
   
   Also added a test for the corner cases.

   32bd837332
3. MarcoFalke added the label Refactoring on Jul 26, 2022
4. 
   MarcoFalke commented at 12:56 pm on July 26, 2022: member

   I have only cherry-picked this for conceptual discussion. I have not yet run a benchmark. cc @martinus
5. 
   MarcoFalke commented at 3:00 pm on July 26, 2022: member

   This needs the sanitizer warning fixed somehow, so I am leaving it for others to pick up, if they want.
6. MarcoFalke closed this on Jul 26, 2022

   ---

7. MarcoFalke deleted the branch on Jul 26, 2022
8. fanquake added the label Up for grabs on Jul 26, 2022
9. bitcoin locked this on Jul 26, 2023

Contributors
MarcoFalke

Labels
Refactoring Up for grabs