build: Fix help string for `--enable-external-signer` configure option #25770

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:220802-signer changing 1 files +1 −1

hebasto commented at 10:37 AM on August 2, 2022: member

This PR is a follow up of bitcoin/bitcoin#24065 and fixes the help string according to the actual default value https://github.com/bitcoin/bitcoin/blob/816ca01650f4cc66a61ac2f9b0f8b74cd9cd0cf8/configure.ac#L324-L327
build: Fix help string for `--enable-external-signer` configure option 8df063e537
fanquake added the label Build system on Aug 2, 2022
kristapsk approved
kristapsk commented at 11:12 AM on August 2, 2022: contributor

cr utACK 8df063e53712b69a346a83c599ca9cb83905b70b

in configure.ac:325 in 8df063e537

 321 | @@ -322,7 +322,7 @@ AC_ARG_ENABLE([werror],
 322 |      [enable_werror=no])
 323 |  
 324 |  AC_ARG_ENABLE([external-signer],
 325 | -    [AS_HELP_STRING([--enable-external-signer],[compile external signer support (default is yes, requires Boost::Process)])],
 326 | +    [AS_HELP_STRING([--enable-external-signer],[compile external signer support (default is auto, requires Boost::Process)])],

jarolrod commented at 4:56 PM on August 2, 2022:

the default is auto, you can also supply yes and no. Should we follow the convention used elsewhere of specifying the possible inputs, so for example, the help output could be:

--enable-external-signer[=yes|no|auto]
                          compile external signer support (default is auto,
                          requires Boost::Process)

jarolrod commented at 4:56 PM on August 2, 2022: member
ACK 8df063e53712b69a346a83c599ca9cb83905b70b

This is correct, it's documented in the code a few lines below :)

relevant output of ./configure -help on this PR branch:
```
--enable-external-signer
                          compile external signer support (default is auto,
                          requires Boost::Process)
```
fanquake merged this on Aug 4, 2022
fanquake closed this on Aug 4, 2022
hebasto deleted the branch on Aug 4, 2022
sidhujag referenced this in commit 1372bb62f5 on Aug 4, 2022
bitcoin locked this on Aug 4, 2023

Contributors

Labels