test: Target exact weight in MiniWallet _bulk_tx #25773

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2208-test-exact-bulk-weight-🏞 changing 2 files +10 −7

MarcoFalke commented at 10:05 AM on August 3, 2022: member

Seems better to target the exact weight than a weight that is up to more than 2000 WU larger.

Also, replace a broad -acceptnonstdtxn=1 with -datacarriersize=100000 to document the test assumptions better.

test: Target exact weight in MiniWallet _bulk_tx

Also, replace broad -acceptnonstdtxn=1 with -datacarriersize=100000

fa2537cf0a

fanquake added the label Tests on Aug 3, 2022
glozow requested review from theStack on Aug 4, 2022
theStack approved
theStack commented at 1:24 PM on August 4, 2022: contributor
Code-review ACK fa2537cf0a7629d81df1bc5b4ae6a22dc572647b

TIL that the Python repetition operator * also accepts negative values and simple yields empty (byte-)strings in that case:
```
>>> b'a' * -1337
b''
```
(Intuitively, I would have preferred to keep the first assertion, checking that the target weight is larger than the current tx's weight, in order to prevent a negative dummy_vbytes value, but it doesn't seem to have any negative consequences (no pun intended)🤷‍♂️ ).
MarcoFalke merged this on Aug 4, 2022
MarcoFalke closed this on Aug 4, 2022
MarcoFalke deleted the branch on Aug 4, 2022
sidhujag referenced this in commit dea25f0755 on Aug 4, 2022
bitcoin locked this on Aug 4, 2023

Contributors

Labels