. #25795

issue lish2099 opened this issue on August 6, 2022
  1. lish2099 commented at 2:47 PM on August 6, 2022: none

    Been thinking about this and pushed some refactoring that you might like a bit more.

    The idea was based on try to not mix the Coin Selection code with the inputs fetching while still be able to remove the manual coins selection stuff from the automatic coin selection, the extra loops for the pre-set inputs and the FetchCoins wrapper function.

    So, have decoupled the SelectCoins into two functions:

    1. AutomaticCoinSelection: Which is basically the previously called SelectCoins without the manually selected inputs stuff. So, it will purely receive a set of coins and be in charge of selecting the best subset of them to cover the target amount.

    2. SelectCoins: In charge of selecting all the user manually selected coins first ("pre-set inputs"), and if coin_control 'm_allow_other_inputs=true', call 'AutomaticCoinSelection' to select a set of coins such that the target - pre_set_inputs.total_amount is met. Then merge both results.

    _Originally posted by @furszy in #25685 (review) _

  2. fanquake closed this on Aug 6, 2022

  3. fanquake locked this on Aug 6, 2022
  4. fanquake renamed this:
    Been thinking about this and pushed some refactoring that you might like a bit more.
    .
    on Aug 6, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me