net: simplify GetLocalAddress() #25814

pull vasild wants to merge 1 commits into bitcoin:master from vasild:simplify_GetLocalAddress changing 1 files +2 −3

vasild commented at 1:13 PM on August 10, 2022: contributor

There is no need to use two variables ret and addr of the same type CService and assign one to the other in a strange way like ret = CService{addr}.

net: simplify GetLocalAddress()

There is no need to use two variables `ret` and `addr` of the same type
`CService` and assign one to the other in a strange way like
`ret = CService{addr}`.

daabd41211

fanquake added the label P2P on Aug 10, 2022
jarolrod approved
jarolrod commented at 7:27 PM on August 10, 2022: member

ACK daabd4121114fe6f780bccab311a522c0717c5b8

Can still see my local addresses in the -netinfo dashboard.
aureleoules commented at 9:45 AM on August 11, 2022: member

ACK daabd4121114fe6f780bccab311a522c0717c5b8. I verified that the behavior has not changed and the code is simplier.
w0xlt approved
w0xlt commented at 8:31 PM on August 11, 2022: contributor

ACK https://github.com/bitcoin/bitcoin/pull/25814/commits/daabd4121114fe6f780bccab311a522c0717c5b8
MarcoFalke merged this on Aug 12, 2022
MarcoFalke closed this on Aug 12, 2022
vasild deleted the branch on Aug 12, 2022
sidhujag referenced this in commit 34bf2f0400 on Aug 12, 2022
bitcoin locked this on Aug 12, 2023

Contributors

Labels