test: Use existing {Chainstate,Block}Man #25815

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2208-test-cherry-🥕 changing 2 files +4 −18
  1. MarcoFalke commented at 2:43 pm on August 10, 2022: member

    This is split up because it is needed for two changes:

  2. validation tests: Use existing {Chainstate,Block}Man
    Use {Chain,}TestingSetup's existing {Chainstate,Block}Manager and avoid
    unnecessarily creating a local one.
    
    This also helps reduce the code diff for a later commit where we change
    {Chainstate,Block}Manager's constructor signature.
    2e79fb6585
  3. MarcoFalke commented at 2:44 pm on August 10, 2022: member
    (Taken from e6336ea7de0c9e91318e33023e236148a14b7fbd)
  4. fanquake added the label Tests on Aug 10, 2022
  5. adam2k commented at 6:22 pm on August 10, 2022: none

    ACK tested 2e79fb6585c802813f80080fc2cadc5b54ddebfb

    Thanks for the context in the linked PRs. 🙏

  6. aureleoules commented at 9:40 am on August 11, 2022: member
    ACK 2e79fb6585c802813f80080fc2cadc5b54ddebfb. I verified that this change only renames boost testsuites and removes redundant code.
  7. fanquake requested review from dongcarl on Aug 11, 2022
  8. adam2k approved
  9. MarcoFalke merged this on Aug 11, 2022
  10. MarcoFalke closed this on Aug 11, 2022

  11. MarcoFalke deleted the branch on Aug 11, 2022
  12. sidhujag referenced this in commit 49df5a5dd7 on Aug 11, 2022
  13. bitcoin locked this on Aug 11, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me