This is split up because it is needed for two changes:
test: Use existing {Chainstate,Block}Man #25815
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2208-test-cherry-🥕 changing 2 files +4 −18-
MarcoFalke commented at 2:43 PM on August 10, 2022: member
-
2e79fb6585
validation tests: Use existing {Chainstate,Block}Man
Use {Chain,}TestingSetup's existing {Chainstate,Block}Manager and avoid unnecessarily creating a local one. This also helps reduce the code diff for a later commit where we change {Chainstate,Block}Manager's constructor signature. -
MarcoFalke commented at 2:44 PM on August 10, 2022: member
(Taken from e6336ea7de0c9e91318e33023e236148a14b7fbd)
- fanquake added the label Tests on Aug 10, 2022
-
adam2k commented at 6:22 PM on August 10, 2022: none
ACK tested 2e79fb6585c802813f80080fc2cadc5b54ddebfb
Thanks for the context in the linked PRs. 🙏
-
aureleoules commented at 9:40 AM on August 11, 2022: member
ACK 2e79fb6585c802813f80080fc2cadc5b54ddebfb. I verified that this change only renames boost testsuites and removes redundant code.
- fanquake requested review from dongcarl on Aug 11, 2022
- adam2k approved
- MarcoFalke merged this on Aug 11, 2022
- MarcoFalke closed this on Aug 11, 2022
- MarcoFalke deleted the branch on Aug 11, 2022
- sidhujag referenced this in commit 49df5a5dd7 on Aug 11, 2022
- bitcoin locked this on Aug 11, 2023